[Bug 167034] Review Request: foremost -- Recover files by "carving" them from a disk image

bugzilla at redhat.com bugzilla at redhat.com
Thu Sep 29 04:03:41 UTC 2005


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: foremost -- Recover files by "carving" them from a disk image


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=167034





------- Additional Comments From mpeters at mac.com  2005-09-29 00:03 EST -------
Given that the Makefile supports a configuration file path as an option,
upstream should honer that option when make is run.

It should be filed as a bug with upstream.
The patch is fine with me, but a cleaner solution might be to use sed within
%prep to fix it - so that it can be replaced with the %_sysconfdir and thus
build on systems that have a custom %_sysconfdir (like /opt/etc or whatever)

cp config.c config.c.org
sed -e s?"/usr/local/etc"?"%{_sysconfdir}"? < config.c.orig > config.c

(or use sed -i - as he already does in one spot)

Whatever Toshio wants to do until upstream fixes it would be fine with me.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the fedora-extras-list mailing list