[Bug 182040] Review Request: ratpoison - simplified keyboard-only window manager

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ratpoison - simplified keyboard-only window manager


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=182040


kevin at tummy.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|bugzilla-sink at leemhuis.info |kevin at tummy.com
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From kevin at tummy.com  2006-04-06 22:30 EST -------
Here's A review:

MUST items:

See below - rpmlint output
OK - Package name.
OK - Spec file name matches.
OK - Package guidelines.
OK - License. (GPL)
OK - License field matches in spec.
OK - License included in files.
OK - Spec in american english.
OK - md5sum of source from upstream
75541248c355a3f1e09e864dd23a43f4  ratpoison-1.3.0.tar.gz
75541248c355a3f1e09e864dd23a43f4  ratpoison-1.3.0.tar.gz.1
OK - Compiles and builds on one arch at least.
OK - No forbidden buildrequires included
OK - Owns all directories it creates.
OK - No duplicate files in %files listing.
OK - Permissions on files correct.
OK - Clean section correct.
OK - Macros consistant.
OK - Code not content.
OK - Doesn't own any files/dirs that are already owned by other packages.

Items needing attention:

1. Not a blocker, but 1.4.0 is out.

2. blocker: BuildRequires: xorg-x11-devel isn't valid in fc5 and
later. Builds ok on fc4.
Suggest: 'BuildRequires: libX11-devel' for devel/fc5.

3. blocker: unpackaged files on build:
warning: Installed (but unpackaged) file(s) found:
   /usr/share/info/dir
Suggest: adding to the end of install:
rm -f ${RPM_BUILD_ROOT}/%{_infodir}/dir

4. Requires: aren't needed at all. Can be removed. rpm will detect them.

5. rpmlint has some output:
W: ratpoison strange-permission ratpoison.desktop 0755
E: ratpoison script-without-shellbang /usr/share/xsessions/ratpoison.desktop

Can be ignored.

E: ratpoison non-executable-script /usr/share/ratpoison/allwindows.sh 0644
E: ratpoison non-executable-script /usr/share/ratpoison/genrpbindings 0644
E: ratpoison non-executable-script /usr/share/ratpoison/rpshowall.sh 0644
E: ratpoison non-executable-script /usr/share/ratpoison/split.sh 0644
E: ratpoison non-executable-script /usr/share/ratpoison/clickframe.pl 0644
E: ratpoison non-executable-script /usr/share/ratpoison/rpws 0644

These should all probibly be 755?

E: ratpoison info-files-without-install-info-postin
/usr/share/info/ratpoison.info.gzE: ratpoison
info-files-without-install-info-postun /usr/share/info/ratpoison.info.gz
Should use install-info in postin, and postun?


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.