[Bug 182463] Review Request: cairomm (C++ bindings for cairo)

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: cairomm (C++ bindings for cairo)


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=182463





------- Additional Comments From rvinyard at cs.nmsu.edu  2006-04-09 14:06 EST -------
Spec Name or Url: http://miskatonic.cs.nmsu.edu/pub/cairomm.spec

SRPM Name or Url: http://miskatonic.cs.nmsu.edu/pub/fedora/5/srpms/cairomm-0.6.
0-1.src.rpm

Summary of changes:
- New upstream release
- Added docs back in by moving them in install and including in devel files

Other changes from feedback:
* missing "BuildRequires: pkgconfig"
 - ADDED

* cairomm-devel should really "Requires: pkgconfig", because (1) it
contains a pkg-config file and (2) the library headers are stored in
a path that is unlikely to be found if pkg-config is not used
 - ADDED to cairomm BuildRequires and cairomm-devel Requires

* prefer "make DESTDIR=%{buildroot} install" over %makeinstall, since
while the former is de facto standard, the latter is just a hack
 - CHANGED

* AUTHORS %doc file is about libxmlplusplus and points to its home page
 - UPSTREAM RELEASE fixes this

* README %doc file has libxml++ at the top, very confusing, both files
should really be corrected
 - UPSTREAM RELEASE fixes this

* Also note that the cairomm-devel package contains more than "headers
and static library". ;)  The very important *.so symlink is included, too.
 - CHANGED

* As a hint at the bottom:
 - CHANGED to the latter suggestion... directory style


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.