[Bug 188376] Review Request: perl-Test-Tester

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Test-Tester


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=188376


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |




------- Additional Comments From tibbs at math.uh.edu  2006-04-09 14:25 EST -------
Builds fine in mock (development branch) and rpmlint is silent.

Issues:
The package says it's under the same license as perl, but then includes the file
"ARTISTIC" and makes no mention of the GPL.  Odd; upstream should be whacked,
but not a blocker.

Review:
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written, uses macros consistently and
conforms to the Perl template.
* license field matches the actual license.
* license is open source-compatible and license text is included in the package.
* source files match upstream:
   31d58158d2a6cdb7ad9d9fe3e0aed86e  Test-Tester-0.103.tar.gz
   31d58158d2a6cdb7ad9d9fe3e0aed86e  Test-Tester-0.103.tar.gz-srpm
* package builds in mock.
* BuildRequires are proper.
* final provides and requires are sane.
* no shared libraries are present.
* package is not relocatable.
* owns the directory it creates.
* no duplicates in %files.
* file permissions are appropriate.
* %clean is present.
* %test is present and all tests pass.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no libtool .la droppings.
* not a GUI app.
* The package owns %{perl_vendorlib}/Test, which will probably also be owned by
any module under the Test:: namespace.  However, none of the dependencies create
this directory so there is no alternative but for this package to own it.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.