[Bug 188461] Review Request: xmms-musepack - Mpegplus (mpc) playback plugin for XMMS
bugzilla at redhat.com
bugzilla at redhat.com
Tue Apr 11 18:24:45 UTC 2006
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: xmms-musepack - Mpegplus (mpc) playback plugin for XMMS
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=188461
eric.tanguy at univ-nantes.fr changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |eric.tanguy at univ-nantes.fr
------- Additional Comments From eric.tanguy at univ-nantes.fr 2006-04-11 14:24 EST -------
Review for release 2.fc5:
* RPM name is OK
* This is the latest version
* Builds fine in mock
* rpmlint of xmms-musepack looks OK
* File list of xmms-musepack looks OK
Needs work:
* Source 0 is not available
(http://musepack.origean.net/files/linux/plugins/xmms-musepack-1.2.tar.bz2)
(wiki: QAChecklist item 2)
* BuildRoot should be %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
(wiki: PackagingGuidelines#BuildRoot)
* BuildRequires: gcc-c++ should not be included
(wiki: PackagingGuidelines#Exceptions)
Maybe you could add %{?dist} in the release. It could be usefull for next fedora
version (ie fc6)
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
More information about the fedora-extras-list
mailing list