[Bug 188623] Review Request: SOAPpy - Full-featured SOAP library for Python

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: SOAPpy - Full-featured SOAP library for Python


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=188623


wart at kobold.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|bugzilla-sink at leemhuis.info |wart at kobold.org
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From wart at kobold.org  2006-04-17 10:39 EST -------
MUST
====
* rpmlint output clean
* Source matches upstream.  md5sum:
  51ac835366badedd932c64f26fa8336b  SOAPpy-0.11.6.tar.gz
* License (PSFL) ok, license file included
* Package and spec file named appropriately
* Spec file legible and in Am. English
* Builds and packages in mock on FC-4 i386, FC-4 x86_64, devel i386, devel x86_64
* No locales
* No shared libraries
* Not relocatable
* buildroot cleaned in at beginning of %install and in %clean
* No duplicate files
* Macro use consistent
* Contains code, not content
* No -devel package necessary
* No .la archives
* No .desktop file needed
* Owns all directories that it creates.

SHOULD
======
* There are some unit tests in the tests subdirectory.  Consider running
  the test suite in the spec file to verify that the package works.

* There are a lot of example scripts in contrib/, bid/, validate that could
  be included as example code in %doc.

MUSTFIX
=======
* Is BuildRequires: PyXML necessary?  It seems to build fine without it.
* The files in the docs subdirectory need to be added to %doc.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.