[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[Bug 174588] Review Request: libopensync-plugin-gpe



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libopensync-plugin-gpe


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=174588


jpmahowald gmail com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|gdk redhat com              |jpmahowald gmail com
OtherBugsDependingO|163776                      |163779
              nThis|                            |




------- Additional Comments From jpmahowald gmail com  2006-02-05 03:02 EST -------
Minor: 
- warnings while building:

gpesync_client.c: In function 'write_command':
gpesync_client.c:70: warning: ignoring return value of 'write', declared with
attribute warn_unused_result
gpesync_client.c: In function 'gpesync_client_open':
gpesync_client.c:248: warning: ignoring return value of 'pipe', declared with
attribute warn_unused_result
gpesync_client.c:249: warning: ignoring return value of 'pipe', declared with
attribute warn_unused_result

It'd be nice if these went away and we could use -Werror again. File a bug upstream.

- %description too long
rpmlint of libopensync-plugin-gpe-devel-0.18-1.i386.rpm:E:
libopensync-plugin-gpe-devel description-line-too-long The
libopensync-plugin-gpe-devel package contains the files needed for development

rpmlint of libopensync-plugin-gpe-devel-0.18-1.i386.rpm:E:
libopensync-plugin-gpe-devel description-line-too-long The
libopensync-plugin-gpe-devel package contains the files needed for development


Good:

- package meets naming guidelines
- package meets packaging guidelines
- license (GPL) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on FC4 i386
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file

- devel package ok
- no .la files
- post/postun ldconfig ok
- devel requires base package n-v-r 

Fixup the %description and this is APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]