[Bug 181534] Review Request: kst - plots scientific data

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: kst - plots scientific data


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=181534


orion at cora.nwra.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|bugzilla-sink at leemhuis.info |orion at cora.nwra.com
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From orion at cora.nwra.com  2006-02-15 14:01 EST -------
Good:

- package meets naming guidelines
- package meets packaging guidelines
- license (GPL) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- no missing BR
- uses %find_lang
- not relocatable
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- nothing in %doc affects runtime
- devel package ok
- post/postun ldconfig ok
- devel requires base package n-v-r 

Bad:

- This needs to compile on devel first, so it needs to handle modular X. BR
xorg-x11-devel needs to be removed.
- Unnecessary BR:  qt-devel,kdelibs-devel (required by kdebindings-devel)
- Needs to owns all directories that it creates:
  %{_datadir}/apps/kst/
  %{_datadir}/services/kst/
  %{_datadir}/servicetypes/
  %{_libdir}/kde3/kstplugins/

Other notes:

- Might want to change Source0 to:

ftp://ftp.kde.org/pub/kde/stable/apps/KDE3.x/scientific/kst-%{version}.tar.gz

- I'll need to take a look at the desktop files later
- Still working on building in mock and running rpmlint.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.