[Bug 181777] Review Request: CCfits A C++ interface for cfitsio (FITS File Subroutine Library)

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: CCfits A C++ interface for cfitsio (FITS File Subroutine Library)


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=181777


ed at eh3.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|bugzilla-sink at leemhuis.info |ed at eh3.com




------- Additional Comments From ed at eh3.com  2006-02-19 13:27 EST -------
Hi Sergio, I started to do a review of this package and got this far:

good:
 + specfile is legible
 + builds on FC4 (will try in mock later)
 + dir ownership looks good
 + *.la files removed

needswork:
 - Something is the matter with the upstream server.  All my connections
   to it are timing out so I can't get a copy of the upstream code to
   compare.  Hopefully, it'll get fixed soon and we'll be able to proceed!

 - builds on FC4 and rpmlint returns the following:
W: CCfits summary-ended-with-dot A C++ interface for cfitsio (FITS File
Subroutine Library).
W: CCfits invalid-license GPL compatible (see License.txt)
E: CCfits binary-or-shlib-defines-rpath /usr/lib/libCCfits.so.0.0.0 ['/usr/lib']
W: CCfits-devel summary-ended-with-dot Headers for developing programs that will
use CCfits.
W: CCfits-devel invalid-license GPL compatible (see License.txt)
W: CCfits-docs invalid-license GPL compatible (see License.txt)
E: CCfits-docs script-without-shellbang
/usr/share/doc/CCfits-docs-1.4/html/support_subs.pl
E: CCfits-docs wrong-script-interpreter
/usr/share/doc/CCfits-docs-1.4/html/ccfitschange_sff.pl "/usr1/local/bin/perl5"
W: CCfits-docs doc-file-dependency
/usr/share/doc/CCfits-docs-1.4/html/ccfitschange_sff.pl /usr1/local/bin/perl5

 - The license is essentially BSD without the advertisement clause, so
   please list it as BSD (which is GPL-compatible)
 - Please change the main Summary: to "A C++ interface for cfitsio" and
   remove the trailing "."-s in the others
 - the "rpath" mentioned above will probably need to be fixed

And I'm sorry this isn't a full review -- am going to need to get a copy
from upstream to complete it.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.