[Bug 174898] Review Request: perl-HTML-FillInForm

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-HTML-FillInForm


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=174898





------- Additional Comments From mpeters at mac.com  2006-01-04 04:40 EST -------
Please change the URL to

http://search.cpan.org/dist/HTML-FillInForm/

Please change Source0 to

ftp://ftp.cpan.org/pub/CPAN/modules/by-module/HTML/HTML-FillInForm-%{version}.tar.gz

Requires:       perl-HTML-Parser
normall you want to change that to
Requires:       perl(HTML::Parser)
However - looking at the mock build.log - it seems that rpm picks that up
itself, so the explicit requires should just by removed.

Provides: perl(HTML::FillInForm) = 1.06
Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(VersionedDependencies) <= 3.0.3-1
Requires: perl >= 0:5.005 perl(:MODULE_COMPAT_5.8.6) perl(Carp)
perl(HTML::Parser) >= 3.26 perl(integer) perl(strict) perl(vars) perl-HTML-Parser
Checking for unpackaged file(s): /usr/lib/rpm/check-files /var/tmp/perl-HTML-Fil
lInForm-1.06-4.fc4-root-mockbuild

rpmlint error on src.rpm:

[mpeters at jerusalem result]$ rpmlint *.rpm
W: perl-HTML-FillInForm strange-permission HTML-FillInForm-1.06.tar.gz 0600

You probably shour chmod 644 the src.tarball before building the src.rpm

-=-

* md5sum matches upstream
* mock build clean (tested in FC4)
* Appropriate License (GPL or Artistic) - matches tarball (as described in
README file)
* Written in American English
* specfile name matches package
* follows guidelines for naming of perl modules
* follows example spec file for perl modules
* proper and consistent use of macros
* No un-necessary BuildRequires
* cleanly installs / uninstalls (proper %files section)

Fix the issues noted and I'll approve.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.