[Bug 173054] Review Request: wavpack - completely open audiocodec

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: wavpack - completely open audiocodec


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=173054





------- Additional Comments From lemenkov at newmail.ru  2006-01-07 10:06 EST -------
>   It is commonly considered bad taste to mention the software name
>   in the Summary line. Keep the summary short and include relevant
>   keywords. That's enough. More details fit into the package description.

Done.

>   Probably also  s/wavpack/WavPack/gi  since that is how they
>   spell it online.

Done. Except the RPM-name.

> * pkgconfig template file wavpack.pc.in contains hardcoded libdir,
>   which most likely breaks on multilib platforms if installed like
>   that. Needs a patch which does  libdir=@libdir@  instead of 
>   libdir=${prefix}/lib  and provided that libdir will be defined and
>   substituted by the used autotools framework.
> * pkgconfig file Cflags line is questionable. Adding a standard path
>   for headers to the search list is dangerous. Also, are WavPack
>   API users expected to do #include <wavpack/wavpack.h> or
>   #include <wavpack.h>? In case of the latter, the pkgconfig file
>   is wrong.
>   Same for Libs line. -L${libdir} disturbes library location search list
>   because libwavpack.so is installed into a standard location.

Done.

I also updated spec-file due to mainstream version change (4.3 -> 4.31).

Spec Name or Url: http://lemenkov.newmail.ru/SPECS/wavpack.spec
SRPM Name or Url: http://lemenkov.newmail.ru/SRPMS/wavpack-4.31-1.src.rpm


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.