[Bug 177083] Review Request: xmldiff

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xmldiff


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=177083





------- Additional Comments From ville.skytta at iki.fi  2006-01-08 06:19 EST -------
Doing the manpage charset conversion in %install will break --short-circuit
builds as the pages will be converted more than one time.  Moving that to %prep
fixes it.

Relying on docbook-style-xsl to pull in sgmlnorm is fragile.  sgmlnorm has been
moved to the new opensp package in Rawhide and docbook-style-xsl doesn't really
require either openjade or opensp; it's more like an implementation glitch in
the current docbook-dtds package.  Requires: /usr/bin/sgmlnorm would make this
more robust.

No need to define python_sitelib at top of specfile, it's not used.

To enable the test suite, add BuildRequires: python-logilab-common and after
%install:
    %check
    cd test
    PYTHONPATH=$(ls -1d $PWD/../build/lib.*) %{__python} runtests.py


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.