[Bug 177038] Review Request: perl-version: Perl extension for Version Objects

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-version: Perl extension for Version Objects


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=177038





------- Additional Comments From rc040203 at freenet.de  2006-01-08 23:22 EST -------
Some remarks on this excerpt from the spec:
sed -i "s|#!perl|#!%{_bindir}/perl|g" lib/version.pm
sed -i "s|#!perl|#!%{_bindir}/perl|g" lib/version/vxs.pm

1. You'd better use %{__perl} instead of %{_bindir}/perl in the sed pattern above.

2. These 2 lines could be written as one:
sed -i ...  lib/version.pm lib/version/vxs.pm

3. The "global modifier" (.../g) in the sed pattern isn't necessary.

I'll approve the package when point 1 has been addressed.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.