[Bug 174377] Review Request:gnu-smalltalk - GNU Smalltalk

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request:gnu-smalltalk - GNU Smalltalk


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=174377





------- Additional Comments From rc040203 at freenet.de  2006-01-09 11:41 EST -------
(In reply to comment #20)
> it will be nice, if any may approve the package.
Well, IMO, this package still needs quite some love before it can be approved.

I tried to build your *-5.rpm and am still seeing quite a lot of arguable details:

1. /usr/bin/gst contains a invalid rpath.

2. Disable building the static libs.

3. Many of the *st scripts in /usr/share carry a broken SHEBANG and broken
permissions.

4. Please explain the purpose of the *-am.patch.
In its core, the package renames the package (comprising the tarball's name!)
and should not be applied. IMO this patch should not be applied.

5. make check should be moved to %check
...


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.