[Bug 177401] Review Request: clamsmtp - SMTP filter for ClamAV
bugzilla at redhat.com
bugzilla at redhat.com
Tue Jan 10 15:04:58 UTC 2006
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: clamsmtp - SMTP filter for ClamAV
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=177401
rpm at timj.co.uk changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |rpm at timj.co.uk
------- Additional Comments From rpm at timj.co.uk 2006-01-10 10:04 EST -------
(NB I am not a reviewer, these are just comments)
1. BuildRoot should probably be:
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
2. $rpm -ivh clamsmtp-1.6-1.i386.rpm
Preparing... ########################################### [100%]
1:clamsmtp ########################################### [100%]
error reading information on service clamsmtpd: No such device
error: %post(clamsmtp-1.6-1.i386) scriptlet failed, exit status 1
This is because the clamsmtpd init script is ending up in a subdirectory:
$ls -ld /etc/init.d/clamsmtpd
drwxr-xr-x 2 root root 4096 Jan 10 14:37 /etc/init.d/clamsmtpd
fix to the spec:
32c32
< %{__install} -d %{buildroot}%{_initrddir}/clamsmtpd
---
> %{__install} -d %{buildroot}%{_initrddir}
3. rpmlint says:
E: clamsmtp non-standard-gid /etc/clamsmtpd.conf clamav
This is tricky. clamsmtp does require clamav, which creates the clamav user in
its %post, but that seems a bit fragile in case the clamav package changes.
Also, the "clamav" user in the clamav package owns the virus databases, so
having daemons run as the same user is not a good idea. It would probably be
better for the package to create its own "clamsmtp" user to run as and own the
config.
4.
W: clamsmtp no-reload-entry /etc/rc.d/init.d/clamsmtpd
from "man clamsmtpd" it does not have a reload signal.
W: clamsmtp incoherent-init-script-name clamsmtpd
It would probably be better to rename this to "clamsmtp", to match the package
name. Ditto the init file refers to "ClamSmtpd" which should perhaps be "clamsmtp"
4. I wonder if /etc/clamsmtpd.conf should be mode 0640 rather than 0644, for
privacy?
5. the %doc "scripts/clamsmtpd.sh" can probably be removed, it seems to just be
a crude init script.
other than that, a few things I checked:
- Naming looks OK
- license is OK (BSD)
- license in spec matches package
- license is packaged in %doc
- spec file is in en_US
- spec is legible
- source matches upstream
- package builds
- package superficially works (it runs)
- ldconfig not necessary
- no locales
- no relocation
- no directories created and therefore needing ownership
- permissions look ok
- %clean is present
- package uses macros
- %doc is docs. scripts/virus_action.sh is an example, so that's OK.
- scriptlets look sane, with Requires(post) and (postun)
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
More information about the fedora-extras-list
mailing list