[Bug 177588] Review Request: mysql-administrator

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mysql-administrator


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=177588


chabotc at xs4all.nl changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Review Request: mysql-      |Review Request: mysql-
                   |administrator               |administrator
                 CC|                            |chabotc at xs4all.nl
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From chabotc at xs4all.nl  2006-01-11 22:25 EST -------
I've compiled & verified the functionality on devel, and taken an initial look
at the spec file.

I did notice it got confused and hung a few times while forinstance trying to
get the user list.. Also the help menu->contents doesn't do anything, but these
might be upstream issues.

I've noticed the %dir %{_datadir}/mysql-gui/administrator/ with the trailing /,
i didn't think it needed to be there?

Also rpmbuild gave me the following error:
warning: Installed (but unpackaged) file(s) found:
   /usr/share/locale/de/LC_MESSAGES/mysql-gui-common.mo
   /usr/share/locale/ja/LC_MESSAGES/mysql-gui-common.mo
   /usr/share/locale/pt_BR/LC_MESSAGES/mysql-gui-common.mo

which indicates you forgot to include the find_lang macro to pick up the
language files:

%install 
.....
%find_lang mysql-gui-common

and in the mysql-gui-common files part:
%files -n mysql-gui-common -f mysql-gui-common.lang 

rpmlint didn't report any errors for the build packages

I'll try to do a mock build and an official review checklist once the packaging
errors mentioned above are corrected.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.