[Bug 176542] Review Request: gnome-yum - GNOME interface for YUM

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gnome-yum - GNOME interface for YUM


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=176542





------- Additional Comments From chabotc at xs4all.nl  2006-01-14 09:24 EST -------
Few last comments before i can do a complete formal review checklist:

- Its not Buildrequires but: BuildRequires: (notice the capital R)

- %changelog doesn't have to include the upstream (source) changes, but the
changes you made to the package, ie:

* Sat Jan 14 2006 András Tóth  <toth_bandi at users.sourceforge.net> - 0.1.2-6 
- Fixed desktop file vendor
- Owned complete datadir
- Changed clean section to be fedora compliant
- find_lang can use %{name} macro, doesn't need to hard-code 'gnome-yum'

And so on .. Your expected to add such a changelog entry for every 'release' of
the package you make (ie up the version or release field) describing what you
changed in the specfile. Its not required to list what changed in 'gnome-yum'
its self,only what you changed of the package / specfile

- attr for gyum-query.sh doesn't have to go thru a defattr, you could just do:
%attr(0755,root,root) %{_datadir}/gnome-yum/gyum-query.sh 

- desktop file install misses:
   --add-category X-Fedora

- Missing BuildRequires entry: libgnomeui-devel

Thats it i think, great progress so far! Once these final issues are resolved
i'll give it the final formal run thru


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.