[Bug 176542] Review Request: gnome-yum - GNOME interface for YUM

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gnome-yum - GNOME interface for YUM


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=176542


chabotc at xs4all.nl changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |




------- Additional Comments From chabotc at xs4all.nl  2006-01-14 17:10 EST -------
Looks good, the formal review:

MUST review items:
- Builds cleanly on FC5 devel.
- rpmlint has no output / complaints
- Source included matches upsteam source (md5sum)
- Package name meets guidelines
- spec file name is in %{name}.spec format
- Licence (GPL) is fedora extra's compatible & is included in spec
- Spec file is in (american) english
- Does not list buildrequires that are excepted in the package guidelines
- All build dependencies are listed
- No ldconfig needed
- All files have proper permissions
- Package is not relocatable
- No duplicate files in %files section
- No missing files in %files section
- Has a proper %clean section with rm -rf $RPM_BUILD_ROOT
- Uses macro's described in PackagingGuidelines
- No entries in %doc that are required for standard program operation
- No -devel package needed
- No directory-ownerships needed

Should items:
- Includes upstream licence file (COPYING)
- No insane scriplets
- No unnescesarry requires

rpmlint's only warning is:
W: gnome-yum no-dependency-on usermode-consoleonly

Mock builds cleanly for fc-devel

Please read:
- http://fedoraproject.org/wiki/Extras/NewPackageProcess and
- http://fedoraproject.org/wiki/Extras/Contributors and 
- http://fedoraproject.org/wiki/Extras/UsingCvsFaq

Carefully for the next steps


FE-APPROVED


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.