[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[Bug 176982] Review Request: RSSOwl - an RSS/RDS/Atom Newsreader



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: RSSOwl - an RSS/RDS/Atom Newsreader


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=176982


chabotc xs4all nl changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |




------- Additional Comments From chabotc xs4all nl  2006-01-16 16:47 EST -------
Formal review list:

MUST review items:
- Builds cleanly on FC5 devel.
- Source included matches upsteam source (md5sum)
- Package name meets guidelines
- spec file name is in %{name}.spec format
- Licence is fedora extra's compatible & is included
- Spec file is in (american) english
- Does not list buildrequires that are excepted in the package guidelines
- All build dependencies are listed
- No ldconfig needed
- All files have proper permissions
- Package is not relocatable
- No duplicate files in %files section
- No missing files in %files section
- Has a proper %clean section with rm -rf $RPM_BUILD_ROOT
- Uses macro's described in PackagingGuidelines
- No entries in %doc that are required for standard program operation
- No -devel package needed
- Proper directory-ownerships
- Proper desktop file & install

Should items:
- Includes upstream licence(s) file
- No insane scriplets
- No unnescesarry requires

Only thing i could not verify of the SHOULD list is the mock build, can't build
this in mock without itext being in extras-development, or to much effort
setting up a local repo to verify, but it looks like it will, so:

FE-ACCEPTED

Thanks for the great & quick work!

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]