[Bug 177782] Review Request: byzanz - A desktop recorder

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: byzanz - A desktop recorder


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=177782





------- Additional Comments From jeff at ollie.clive.ia.us  2006-01-17 15:04 EST -------
(In reply to comment #1)
> ok - MUST: The package must successfully compile and build into binary rpms on
> at least one supported architecture.
> 
> Builds ok under devel.
> Doesn't build on fc4 due to modular X and unavailable gnome packages,
> I assume it's just targeted at devel and beyond.

Yes, the base package requires gnome-vfs2-devel >= 2.12 and libgnomeui-devel >=
2.12.  FC4 only has 2.10.  The modular X dependency could be worked around but I
doubt that FC4 will ever get a newer version of Gnome.

> NEEDINFO MUST items:
> 
> 1 - MUST: A package must own all directories that it creates.
> 
> filesystem package owns /usr/libexec. I guess it's safe to assume filesystem is
> installed, but
> perhaps it should have a explicit requires for it?



> 2 - MUST: Packages containing GUI applications must include a %{name}.desktop
> file, and that file must be properly installed with desktop-file-install in the
> %install section. This is described in detail in the desktop files section of
> PackagingGuidelines. If you feel that your packaged GUI application does not
> need a .desktop file, you must put a comment in the spec file with your
explanation.
> 
> Should this package have a .desktop file since it's got a applet?

I don't think that a .desktop file would be useful since it's just an applet. 
The applet shows up in the "Add to Panel" dialog (right click on a panel and
then select "Add to Panel...").

> 3 - MUST: rpmlint must be run on every package. The output should be posted in
> the review.
> 
> Some rpmlint output:
> 
> W: byzanz summary-ended-with-dot A desktop recorder.
> Should remove . on the end of summary.

Will fix in the next version.

> W: byzanz non-standard-dir-in-usr libexec
> I guess this can be ignored, but see note 1 above.


> SHOULD Items:
> 
> ok - SHOULD: The reviewer should test that the package builds in mock.
> 4 - SHOULD: The package should compile and build into binary rpms on all
> supported architectures.
> 
> I only have a x86 test box. I assume it will build ok on other arches.

I builds in mock on i386/devel and x86_64/devel.

> 5 - SHOULD: The reviewer should test that the package functions as described. ...
> 
> I am getting a segfault when I run the application on my devel test machine.
> I was running inside a vnc session, but tried both Xfce and gnome.
> (I don't have a monitor on my test box right at the moment).
> 
> [...]
>
> Let me know if I can provide any more information on tracking the segfault down. 

This could be related to the use of VNC.  We probably need to bring this
segfault to the attention of the author (Benjamin Otte).  It works in the few
tests that I did on i386/devel system.

I'll post updated packages in a bit.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.