[Bug 178230] Review Request: oneko : Cat chases the cursor

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: oneko : Cat chases the cursor


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=178230





------- Additional Comments From wart at kobold.org  2006-01-18 22:03 EST -------
MUST items:

- rpmlint output is clean
- name is appropriate
- spec filename matches package name
- macro use in spec file is consistent (other than /usr/include; see below)
- Build root is correct
- Summary and description are ok.
- No static libs
- Desktop file looks ok and is installed correctly.
- RPM_OPT_FLAGS passed to make.
- Not relocatable
- Contains code, not content
- Package does not create any directories that it should own.
- spec file is in english and is legible
- Compiles and builds on devel (did not test in mock)
- No shared libraries
- No duplicate %files
- Permissions set correctly
- No -devel package needed

SHOULD items:

- No license file included.  Please query upstream to include one, even
  if it just says that the software is public domain.
- Builds on x86_64-FC4 (with noted changes) and i386-FC5
- Packages runs on both architectures

Non-blocking issues:

%{?_smp_mflags} not passed to make, but there is only one file to compile
so it would have no effect.

The tarball includes a japanese manpage.  Why not include that in the package?

The application itself has some small problems that should be reported upstream:
1) There is no way to turn off oneko.  Once it's started, it runs until you
   log out of X or /usr/bin/kill it manually.  I suspect that this was the
   purpose of the (removed) BSD daemon.
2) If you /usr/bin/kill oneko, the root window cursor reverts to an 'X', not
   a diagonal-arrow as is the default for gnome.

Source does not match upstream due to the removal of the copyrighted images.
All other files were verified the same with 'diff'.

MUSTFIX:

* Several of the included documentation files are in Japanese.  This should
probably be indicated in the filename somehow.

* The 'make' line in the specfile uses "-I /usr/include".  Please change this
to"-I %{_includedir}".

* The patch to the manpage has a grammatical problem:
"a cat wite tiger-like stripe" should be "a cat with tiger-like stripes"
The manpage has other grammatical problems that I'm willing to ignore, but
this line was explicitly fixed by the patch, so it should at least be
grammatically correct.  :)

* BR: xorg-x11-proto-devel is redundant since it's required by libX11-devel.

* 'install' is missing '-p'

Questions:

The spec file says the license is "Public Domain", but I could not find
reference to any license information in the tarball or on the website.
Is this the proper license to use if the author hasn't specified one?
Have you asked upstream what kind of license it falls under?


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.