[Bug 176200] Review Request: Mud Magic Client

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Mud Magic Client


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=176200





------- Additional Comments From paul at city-fan.org  2006-01-26 03:20 EST -------
(In reply to comment #18)
> " * Replace "1.8" with "%{version}" in the Source: tag for easier spec
naintenance "
> this is actually already present, the mudmagic.spec is created during configure
> with mudmagic.spec.in which uses an @VERSION@ variable to output the mudmagic
> source version

Actually I would still suggest making this change. The reason for this is that
although you generate a spec file yourself during configure, that is not the
spec file that is used when you rebuild an SRPM. And since this is a package for
Fedora Extras, the spec file will eventually be held in Fedora's cvs and will
need to be maintained there too. Using %{version} will at least result in
smaller diffs :-)

> " - Use $RPM_BUILD_ROOT or %{buildroot}, not ${RPM_BUILD_ROOT} "
> using %{buildroot} now

There's nothing wrong with ${RPM_BUILD_ROOT} really (as long as you're
consistent about it and don't use $RPM_BUILD_ROOT in the same spec), but
%{buildroot} is fine too (and what I ise in my own specs).

> " - Mock build failed (Also failed on my machine): "
> Rewrote the method of --prefix and --exec-prefix handling for autoconf. I won't
> go into details - but it was a heavy rewrite. included the usage of user defined
> variables for installation directories opposed to hard coded directory locations
> in Makefile.am files and configure.in file.

Build in mock still fails.

Making install in interface
make[1]: Entering directory `/builddir/build/BUILD/mudmagic-1.8/interface'
make[2]: Entering directory `/builddir/build/BUILD/mudmagic-1.8/interface'
/bin/sh ../mkinstalldirs /usr/lib/mudmagic/plugins
mkdir -p -- /usr/lib/mudmagic/plugins
mkdir: cannot create directory `/usr/lib/mudmagic': Permission denied
make[2]: *** [install-exec-local] Error 1
make[2]: Leaving directory `/builddir/build/BUILD/mudmagic-1.8/interface'
make[1]: *** [install-am] Error 2
make[1]: Leaving directory `/builddir/build/BUILD/mudmagic-1.8/interface'
make: *** [install-recursive] Error 1
error: Bad exit status from /var/tmp/rpm-tmp.93171 (%install)

There's a missing $(DESTDIR) in that mkinstalldirs invocation.

> spec:
> http://www.mudmagic.com/mud-client/downloads/mudmagic.spec
> srpm:
> http://www.mudmagic.com/mud-client/downloads/mudmagic-1.8-0.4.src.rpm
> tarball:
> http://www.mudmagic.com/mud-client/downloads/mudmagic-1.8.tar.gz

I'd suggest incrementing the RPM release number each time you change the spec,
and include the release number in the changelog entries, which makes them easier
to follow.



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.