[Bug 172343] Review Request: libtomoe-gtk

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libtomoe-gtk


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=172343





------- Additional Comments From jpmahowald at gmail.com  2006-01-27 09:34 EST -------
How annoying, the sourceforge link doesn't download automatically. md5sum checks
manually though.

Good:

- rpmlint only notices that ldconfig in spec is a one line script. Can ignore,
or use the -p option (wiki: ScriptletSnippets).
- package meets naming guidelines
- package meets packaging guidelines
- license (GPL) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on FC4 i386
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file


- devel package ok
- no .la files
- devel requires base package n-v-r 

Missing ldconfig for the devel package, which I believe is needed. Looks good
otherwise.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.