[Bug 175438] Review Request: smart -- Next generation package handling tool

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: smart -- Next generation package handling tool


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=175438





------- Additional Comments From enrico.scholz at informatik.tu-chemnitz.de  2006-01-28 07:26 EST -------
* Sat Jan 28 2006 Enrico Scholz <enrico.scholz at informatik.tu-chemnitz.de> - 0.41-0.6
- renamed '-gtk' subpackage to '-gui-gtk' to please everybody
- changed group of 'ksmarttray' to Applications/System
- added 'Requires(post): gtk-update-icon-cache' for the -gui-gtk
  subpackage, but NOT for %postun or the ksmarttray package. It does
  not matter whether gtk2 exists at uninstallation: when it exists,
  the cache will be updated; else, the cache is outdated but there is
  nothing which can use it.
  To avoid 'gtk2' dependencies in the KDE subpackage, use a %triggerin
  there for updating the icon-cache and ignore missing programs in
  %postun silently for the reasons told above already.
- added a 'Requires(post): bash' for the main package because a bash
  script is invoked there.
- updated empty-description patch to use this one from upstream SVN
  (rev690+691)


http://ensc.de/fedora/smart.spec
http://ensc.de/fedora/smart-0.41-0.6.src.rpm


==============



> - Why are the source and patch numbers not growing from 1 to 2 etc. (Not
>   really an issue. I just wonder if there's some technical reason for
>   that.)

Allows grouping of related patches/sources without the need to renumber
everything when a new patch/source is added.


> - What's smart-plugins?

The problem with plugins is, that they usually add new dependencies
which are not need for the core functionality. So my first 'smart'
package had a physical '-plugins' subpackage. Because *current*
plugins do not add mentioned dependencies, I merged it back into the
main package.


> - Don't provide smart-tui because the shell is not a tui. 

'smart --shell' is a textual interface for user interaction. So, it
can be labeled 'TUI'... But ok, to make it clear, I renamed it to
'-tui-shell'....


> - Require rpm version >= 4.3 even though it can be overridden with
>   epoch. Just so that the package will tell that rpm >= 4.3 should
>   be used.

README should tell this also... Again: there is absolutely no technical
reason to add versioned dependencies here; the supported environment
(FC4+) has all the needed upstream versions.


> - Change smart-gtk to smart-gui.

Ok, you have won. I renamed it to 'smart-gui-gtk' which should please
everybody.


> - If smart-gui (or smart-gtk) belongs to Applications/System, how
>   can ksmarttray belong to System Environment/Base?

Thx, fixed.


> - Shouldn't smart-usermode obsolete smart-update and not ksmarttray?

'smart-usermode' and 'smart-update' are having completely different
purposes. 'smart-usermode' uses the PAM based userhelper which is
intended for sporadic execution by the user.

'smart-update' is called regularly by 'ksmarttray'; upstream and some
other repos ship it as a SUID wrapper. I think, this is a horrible idea
because of security reason and made it a sudo wrapper. Because only
'ksmarttray' uses it, this package has the needed Provides/Obsoletes.


> - The gui package description should say more clearly that it
>   provides a graphical user interface / frontend.

ok, added a 'GUI' there...


> - Does %configure contain $RPM_OPT_FLAGS?

yes


> - Same goes for "install". Perhaps use the macro instead?

which macro?


> - You use "touch" there. Shouldn't you require /bin/touch then? Or
>   is there a macro for it instead?

'rpmbuild ...' environments should have coreutils installed


> - You use "test" there. The same thing here. Either there is a macro
>   or you should require "/usr/bin/test".

'test' is a bash builtin


> - You use "gtk-update-icon-cache". Shouldn't you require
>   "/usr/bin/gtk-update-icon-cache" then?

thx, it's in the Requires(post): of the -gui-gtk subpackage now; it
does not make sense at other places.


> - And require those commands in the correct package (if used when
>   installing a subpackage, require in subpackage).

???



=======


> Um, that isn't strictly true.  You can run GNOME/GTK apps in a KDE
> environment (e.g. abiword runs fine in KDE) and vice-versa

no; Gnome2 apps do not work fine in non Gnome2 environments because
important configuration settings (e.g. larger fonts) will not be
applied.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.