rpms/perl-Image-ExifTool/devel perl-Image-ExifTool-avoidtheworduse.patch, NONE, 1.1 perl-Image-ExifTool.spec, 1.5, 1.6

[Ralf Corsepius]

On Tue, 2006-07-11 at 10:24 -0500, Jason L Tibbitts III wrote:
> >>>>> "TC" == Tom Callaway <(spot) <fedora-extras-commits at redhat.com>> writes:
> 
> TC> Fix this package so it doesn't grab "perl(the)" as a false dep.
> 
> Wow, by patching out every instance of the word "use" in the source.
> 
> -        } elsif ($format eq 'int16u') {     # use the offset as the value
> +        } elsif ($format eq 'int16u') {     # choose the offset as the value
> 
> Scary.  Which brings up a couple of questions:
> 
> *) Why not just use a dependency filter instead of hacking the source?
>    That patch will have to be redone everytime the source changes.
+1.

This patch means playing with symptoms without providing a cure (fix
rpm's dep generators) nor permanent relief (filtering)

> *) Are of these changes are really necessary?

AFAIS, nope: The culprit seems to be rpm is failing on one single file:

--- lib/Image/ExifTool/MIE.pm~  2006-07-11 17:31:15.000000000 +0200
+++ lib/Image/ExifTool/MIE.pm   2006-07-11 17:31:15.000000000 +0200
@@ -145,7 +145,7 @@
             DNG, EPS, ERF, GIF, ICC, JNG, JP2, JPEG, MIE, MIFF, MNG,
MOS, MOV, MP3, MP4,
             MPEG, MRW, NEF, ORF, PBM, PDF, PGM, PICT, PNG, PPM, PS,
PSD, QTIF, RAF, RAW,
             RIFF, SR2, SRF, TIFF, WAV, WMA, WMV, X3F and XMP.  Other
types should simply
-            use the common file extension.
+            apply the common file extension.
         },
     },
    '1Directory' => { Name => 'SubfileDirectory' },

Ralf