[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Stalled review policy proposal



As discussed at the recent FESCo meeting, I've drawn up a quick policy
for dealing with stalled reviews.  It's not intended to be
comprehensive; the idea is to address two main issues that have been
causing problems in the review process: unresponsive reviewers and
unresponsive package submitters.

The draft is at
http://fedoraproject.org/wiki/JasonTibbitts/StalledReviewPolicy; I
will include a copy below and keep the draft updated with comments I
receive.

A primary item of discussion is now long we should wait before taking
action on a stalled review.  I have proposed one month but at the
FESCo meeting time periods of six and eight weeks were also proposed.

----

Policy for dealing with Stalled Package Reviews

Occasionally package reviews fail to make forward progress due to lack
of response from one of the parties involved in the review. This
policy addresses two classes of reviews: those stalled because the
review submitter is not responding, and those which have been assigned
to a reviewer and are stalled because that reviewer is not
responding. The idea is to move the ticket to a state where other
interested parties can submit the package or take over the review. Of
course there is no intent to punish anyone, and tickets can always be
assigned back to the same reviewer or reopened.

Note: I have chosen below a period of one month of inactivity as the
threshold beyond which a review is considered stalled, and a final
period of one week between notification and action. These are matters
for discussion.

Reviews stalled due to lack of reviewer response

When a review ticket has been assigned to a reviewer and that reviewer
has not responded to comments for one month:

    * A comment should be added to the ticket indicating that the
      review is stalled and that a response is needed soon.
    * If there is no response within one week:
          o The FE-REVIEW blocker is removed and FE-NEW replaces it
          o The ticket is reassigned to [MAILTO]
            nobody fedoraproject org  (Currently there is no
            UNASSIGNED state to move the ticket to.  This also assumes
            that the nobody fedorapeoject org address is actually
            created.)

The intent is to move the ticket back to a state where another
reviewer can work on it. The original reviewer can of course take the
ticket again, but they should be urged to respond in a more timely
manner or Reviews stalled due to lack of submitter response

When the submitter of a review ticket has not responded to comments
for one month:

    * A comment should be added to the ticket indicating that the
      review is stalled and that a response is needed soon.
    * If there is no response within one week:
          o The ticket is closed with resolution NOTABUG.
          o The FE-NEW blocker is removed.

The intent is to close the bug so that it can be submitted by someone
else in a separate bug. If the bug is resubmitted by someone else, it
is also reasonable to change the resolution on the closed bug to
DUPLICATE and mark it as a duplicate of the new bug so that reviewers
of the new ticket can easily find the work that was done on the old
one.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]