[Bug 182737] Review Request: kdetoys

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: kdetoys


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=182737


gauret at free.fr changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|bugzilla-sink at leemhuis.info |gauret at free.fr
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From gauret at free.fr  2006-03-05 11:26 EST -------
Needs work:
* BuildRequires: gettext is missing (required by the %find_lang macro)
* The package should contain the text of the license
  (wiki: Packaging/ReviewGuidelines)
* The package contains libtool archive files (*.la)
  (wiki: PackagingGuidelines#StaticLibraries)
  They can be required by KDE apps sometimes. If it's the case here, it would be
  good to add a comment about it.
* Desktop files: some don't contain the "Application" category, and the "vendor" 
  should be fedora. (wiki: PackagingGuidelines#desktop)

Notes:
* maybe "%{!?debug_package:-strip}" can be dropped in make install ? What do you
think (IIRC it's needed for old distributions only)


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.