[Bug 181777] Review Request: CCfits A C++ interface for cfitsio (FITS File Subroutine Library)

bugzilla at redhat.com bugzilla at redhat.com
Tue Mar 7 02:44:20 UTC 2006


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: CCfits A C++ interface for cfitsio (FITS File Subroutine Library)


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=181777





------- Additional Comments From ed at eh3.com  2006-03-06 21:44 EST -------
OK, I'm glad that the license will be included in future releases.  
Thats good because it clarifies things.  However, that does not mean 
that you should create your own tar-file (as you have done in the last 
two SRPMs) that include the license file.  What you should do is keep 
the source pristine (use an *exact* copy of the upstream tar file) and 
add the license file as a separate patch.

So we still have a blocker here and its the same as before: the souce 
does not match upstream!  Please fix it by either:

 - including the licence file as a aeparate patch, or
 - leaving out the license file (for now) and including it in a 
   later version -- once the upstream folks start shipping it in 
   the official sources

The choice is yours.  But the current form of the SRPM is not acceptable.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the fedora-extras-list mailing list