[Bug 185215] Review Request: adime - Allegro Dialogs Made Easy

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: adime - Allegro Dialogs Made Easy


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=185215





------- Additional Comments From wart at kobold.org  2006-03-12 17:39 EST -------
(In reply to comment #3)
> NONBLOCKING
> ===========
> * License is actually the zlib license, which is very similar to BSD.
>   However, since the zlib package itself claims a BSD license (rpm -qi zlib),
>   this is not a blocker.
>
> I actually had "zlib License" as License tag first, which is for example what
> mandriva uses and rpmlint upstream accepts. Our rpmlint package however
> overrides the list of valid licenses used by upstream and does not include zlib
> hence the change to BSD, which is indeed what zlib uses too. So I can either
> file an RFE against rpmlint to add "zlib License" or leave it as is, waht do you
> think?

I prefer to have the License: tag reflect the actual license as best as it can.
On my FC-4 system /usr/share/rpmlint/TagsCheck.py claims that "zlib License" is
a valid license, but /etc/rpmlint/config doesn't.  It's a valid GPL compatible
license, so rpmlint should be configured to accept it.  Change the License:
tag and file a RFE against rpmlint.

> MUSTFIX
> =======
[...]
> * rpmlint complains on i386 packages:
>   E: adime shlib-with-non-pic-code /usr/lib/libadime.so.0
> Ah an actual problem found by rpmlint how nice (sorry bit sarcastic, see below),
> I fixed this by not using allegro-config --libs as that drags in
> -lalleg_unshareable, which is non-PIC and thus should only be in the application
> and not in a .so file. This means all applications which use us must be
linked> with -Wl,--export-dynamic -lalleg_unsharable (or `allegro-config --libs`)

Now the Makefile has a hardcoded version for the allegro library:
LIB_FLAGS = -lalleg-4.2.0
...making it more sensitive to changes in the allegro version, and also
breaking the build on FC-4.

You could try stripping the offending -lalleg_unsharable flag in the
Makefile:

LIB_FLAGS= $(shell allegro-config --libs | sed 's/-lalleg_unsharable//')

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.