[Bug 179802] Review Request: seamonkey

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: seamonkey


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=179802





------- Additional Comments From kengert at redhat.com  2006-03-14 13:31 EST -------
> Please use %{?_smp_mflags} instead of -j$CPUS and you can get rid of the
> relevant getconf calls.

Ok, changed and removed.

> - %define _unpackaged_files_terminate_build 0
> I just noticed this on.  Can you turn that off and make sure it still builds? 
> If there are unpackaged files, you should explicitly rm them, or list them in
> your %files section with %exclude prepended.

Talked to Chris off-bugzilla. As there are 3500 unpackaged files, it would be a
lot of work to get this cleaned up. As the existing Mozilla package has this
flag turned on, too, we decided to use it for SeaMonkey, too.

> - It would be good to get those scripts that rpmlint complained about 
> changed to 0755 instead of 0775.

Done. Note that rpmlint still complains. But again this warning is produced on
the existing Mozilla packages, too, so that's not new a bug I'm introducing, but
it would be great if we could postpone that.

> - Also, I think it would be good to try and use %ghost to avoid having to do 
> the rm stuff in %preun

I added two more explicitly listed rdf files.
There were no unlisted overlayinfo dirs left, so no need to "rm".
I added the greprefs %dir, so it gets uninstalled properly.
I removed the %preun section.
I did an "install - execute - uninstall" cycle and verified that all files get
removed.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.