[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: rpms/lineakd/devel lineakd.spec, NONE, 1.1 .cvsignore, 1.1, 1.2 sources, 1.1, 1.2



Michael Schwendt wrote:
> On Sun, 21 May 2006 12:27:50 -0700, Chris Petersen wrote:
> 
>> Author: xris
>>
>> Update of /cvs/extras/rpms/lineakd/devel
> 
>> %post
>>
>> /sbin/ldconfig
>>
>> ################################################################################
>>
>> %postun
>>
>> /sbin/ldconfig
>>
>> ################################################################################
> 
> This .spec file should not have been approved in a review. Inserting
> such "#######..." lines in the middle of [and below] scriptlet sections
> bears a big risk. They become part of the scriptlets itself. This causes
> bad breakage in RPM transactions when /bin/sh is not the scriptlet interpreter.
> Has happened before regularly, so avoid "######..." lines like the plague.
> Use multiple empty lines instead.

I'm aware of the issues it creates, but no one could give me a good
reason why it would be a problem to leave things as they are.
Everything I could find told me that RPM uses sh/bash by default when
you don't include a program for %post/etc, so there's no danger of
another interpreter being used that wouldn't know what to do with the
hash character.

Without a valid comment character for rpm (like %# or something like
that), this works WAY better than "lots of whitespace" which is not imho
a good visual separator.  In a small spec like this, it's no big deal,
but I like to keep all of my specs somewhat standardized.

If people *really* feel that this is something that needs to change,
I'll pull the lines and replace them with the shorter form of the
scriptlet, but leaving out a section separators makes for a rather ugly
hard-to-read spec (I already hate having to do it for specs where I
can't rely on sh as the interpreter).

-Chris

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]