[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: rpms/stratagus/devel stratagus--configure-libs.diff, NONE, 1.1 stratagus--configure_in-libs.diff, NONE, 1.1 stratagus.spec, 1.8, 1.9



On Sat, 2006-09-16 at 01:52 -0700, Peter Lemenkov wrote:
> Author: peter
> 
> Update of /cvs/extras/rpms/stratagus/devel
> In directory cvs-int.fedora.redhat.com:/tmp/cvs-serv12592

> --- configure.in	2006-09-16 12:42:28.000000000 +0400
> +++ configure.in	2006-09-16 09:47:55.000000000 +0400
> @@ -2,7 +2,7 @@
>  AC_INIT(configure.in)
>  AC_PREREQ([2.50])
>  
> -CPPFLAGS="$CPPFLAGS -I/usr/local/include -L/usr/local/lib -I/sw/include -L/sw/lib"
> +CPPFLAGS="$CPPFLAGS -I/usr/include -L/usr/lib"
>  
>  AC_CHECK_HEADERS(zlib.h,, AC_MSG_ERROR(could not find zlib.h))
>  AC_CHECK_HEADERS(png.h,, AC_MSG_ERROR(could not find png.h))
> 
> 
This patch is incorrect:

1. Passing -I/usr/include doesn't make sense.

/usr/include is on the compiler's system include path, and is always
implicitly searched, unless the package is playing tricks with compiler
flags.

If the package really requires -I/usr/include, it's bugged.

2. CPPFLAGS is supposed to take preprocessor flags. 
=> -L* isn't a preprocessor flag, so passing -L* through CPPFLAGS is
abusing CPPFLAGS.


Without having checked this package's details you very likely can remove
this CPPFLAGS line from configure.in and configure entirely.

Ralf



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]