[Bug 454078] Review Request: khmeros-fonts - Khmer free/libre font set created by Danh Hong of the Cambodian Open Institute

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: khmeros-fonts - Khmer free/libre font set created by Danh Hong of the Cambodian Open Institute


https://bugzilla.redhat.com/show_bug.cgi?id=454078





------- Additional Comments From nicolas.mailhot at laposte.net  2008-07-04 16:41 EST -------
Formal review

OK  | MUST: rpmlint must be run on every packag…

$ rpmlint *rpm
khmeros-fonts.noarch: E: zero-length /usr/share/doc/khmeros-fonts/COPYRIGHT.Fedora
2 packages and 0 specfiles checked; 1 errors, 0 warnings.

(self-inflicted error, not the proposed file)

OK  | MUST: The package must be named according to the Package…
OK  | MUST: The spec file name must match the base package…
OK  | MUST: The package must meet the Packaging Guidelines…
OK  | MUST: The package must be licensed with a Fedora approved…
OK  | MUST: The License field in the package spec file must…
NOK | MUST: If (and only if) the source package includes the…
Don't add licence files not published upstream

-   | MUST: The spec file must be written in American English.
OK  | MUST: The spec file for the package MUST be legible.
-   | MUST: The sources used to build the package must match… 
Didn't check the srpm.  the spec works fine with the upstream zip

OK  | MUST: The package must successfully compile and build…
N/A | MUST: If the package does not successfully compile, build 
OK  | MUST: All build dependencies must be listed…
N/A | MUST: The spec file MUST handle locales properly…
N/A | MUST: Every binary RPM package which stores shared…
N/A | MUST: If the package is designed to be relocatable…
OK  | MUST: A package must own all directories that it creates
OK  | MUST: A package must not contain any duplicate files 
OK  | MUST: Permissions on files must be set properly. 
OK  | MUST: Each package must have a %clean section
OK  | MUST: Each package must consistently use macros
OK  | MUST: The package must contain code, or permissable 
N/A | MUST: Large documentation files should go in a -doc 
OK  | MUST: If a package includes something as %doc…
N/A | MUST: Header files must be in a -devel package.
N/A | MUST: Static libraries must be in a -static package.
N/A | MUST: Packages containing pkgconfig(.pc) files must…
N/A | MUST: If a package contains library files with a suffix…
N/A | MUST: In the vast majority of cases, devel packages must…
N/A | MUST: Packages must NOT contain any .la libtool archives, 
N/A | MUST: Packages containing GUI applications must include…
OK  | MUST: Packages must not own files or directories already
OK  | MUST: At the beginning of %install, each package MUST…
OK  | MUST: All filenames in rpm packages must be valid UTF-8.

-   | SHOULD: If the source package does not include license 
text(s) as a separate file from upstream, the packager 
SHOULD query upstream to include it.

Please do so

-   | SHOULD: The description and summary sections in the…
OK  | SHOULD: The reviewer should test that the package builds…
N/A | SHOULD: The package should compile and build into binary…
OK  | SHOULD: The reviewer should test that the package…
OK  | SHOULD: If scriptlets are used, those scriptlets must…
N/A | SHOULD: Usually, subpackages other than devel should…
N/A | SHOULD: The placement of pkgconfig(.pc) files depends on…
N/A | SHOULD: If the package has file dependencies outside of…

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.