[Bug 455050] Review Request: padauk-fonts - Padauk font for Burmese and the Myanmar script

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: padauk-fonts - Padauk font for Burmese and the Myanmar script


https://bugzilla.redhat.com/show_bug.cgi?id=455050


nicolas.mailhot at laposte.net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |NEEDINFO
               Flag|                            |needinfo?(mvaliyav at redhat.co
                   |                            |m)




------- Additional Comments From nicolas.mailhot at laposte.net  2008-07-15 07:48 EST -------
1. Upstream unfortunately created an archive with no top-dir. While your
solution will sort-of work people (davej) are going to complain you leave stray
files on the hard drive after a build. When upstream forgets the top-dir in an
archive, use the -c %setup option

2. .txt munging to avoid rpmlint complaining of DOS end-of-files (with a fold
added in as a bonus, notice how we try to preserve the orginal timestamp so it's
build-invariant)

3. use 65 not 61 as fontconfig prefix. As noted on
http://fedoraproject.org/wiki/Fontconfig_packaging_tips#Simple_priority_lists
55-64 space is reserved for fonts with common LGC scripts (and myanmar isn't)

4. minor cosmetic whitespace changes (while I was at it)

5. Lastly, please use Padauk not padauk in your fontconfig rules. As you can
check in nautilus (or another tool) the fonts declare their name with a leading
capital


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.