[Fedora-i18n-bugs] [Bug 532382] Review Request: fvkbd - Free Virtual Keyboard

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=532382





--- Comment #1 from Parag AN(पराग) <panemade at gmail.com>  2009-11-05 00:35:14 EDT ---
Review:
+ package builds in mock (rawhide i686).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1781762
+ rpmlint output for SRPM and for RPM is silent.
+ source files match upstream url(sha1sum)
4c270a703ffa3895a992351dbb4768a550e8dd2f  fvkbd-0.1.6.tar.bz2
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Desktop file installed correctly.
+ Package fvkbd-0.1.6-1.fc13.i686 =>
Provides: libfvkbd-0.1.so.0 libfvkbd-gtk-0.1.so.0
Requires: /usr/bin/python libX11.so.6 libXtst.so.6 libatk-1.0.so.0 libc.so.6
libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.3.4)
libcairo.so.2 libfakekey.so.0 libfontconfig.so.1 libfreetype.so.6
libfvkbd-0.1.so.0 libfvkbd-gtk-0.1.so.0 libgdk-x11-2.0.so.0
libgdk_pixbuf-2.0.so.0 libgio-2.0.so.0 libglib-2.0.so.0 libgmodule-2.0.so.0
libgobject-2.0.so.0 libgtk-x11-2.0.so.0 libpango-1.0.so.0
libpangocairo-1.0.so.0 libpangoft2-1.0.so.0 libunique-1.0.so.0 libxml2.so.2
libxml2.so.2(LIBXML2_2.4.30) libxml2.so.2(LIBXML2_2.6.0) rtld(GNU_HASH)
+ Package fvkbd-devel-0.1.6-1.fc13.i686 =>
Requires: libfvkbd-0.1.so.0 libfvkbd-gtk-0.1.so.0

+ GUI application

Suggestions
1) I don't think you need
Requires: pkgconfig
remove it.
2) menu entry in Accessories is conflicting with matchbox-keyboard name
"Keyboard" though once see difference in icon
But I suggest you change it to 
"Free Virtual Keyboard"

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.