[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [fedora-india] Testing required for menumaker RPM



Hi,

--- On Mon, Jun 1, 2009 at 1:59 PM, Gireesh Sreekantan
<sgireeshmail gmail com> wrote:
| I have cleaned
| up the spec file and built a saner rpm.
\--

Before you re-post your changes, always double check the previous
suggestions that were made, and make sure that they have been fixed.

#01 URL should be the link to the project URL, and not the source!
Source0 should be the pointer to the source. They should be the
following:

URL: http://menumaker.sourceforge.net/
Source0: http://downloads.sourceforge.net/%{name}/%{name}-%{version}.tar.gz

I think it is best to avoid giving a direct mirror URL in Source0. Also see:
https://fedoraproject.org/wiki/Packaging/SourceURL

#03 You incremented the Release number but not in the changelog :)

%changelog
* Mon Jun 1 2009 <sgireeshmail AT gmail DOT com> - 0.99.7-1 <===
- menumaker is now noarch
- gcc is now an implicit BuildRequires
- updated spec file

* Fri May 15 2009 <sgireeshmail AT gmail DOT com> - 0.99.7-1
- updated spec file
- bumped version minor number

It must be:
* Mon Jun 1 2009 <sgireeshmail AT gmail DOT com> - 0.99.7-2

#05: There are still rpmlint errors on the .spec file, generated .rpm
and .src.rpm files.
$ rpmlint menubar.spec
$ rpmlint menumaker-0.99.7-2.noarch.rpm
$ rpmlint menumaker-0.99.7-2.src.rpm

Please fix those. Also refer:
https://fedoraproject.org/wiki/Common_Rpmlint_issues

#08: There is no group called "Applications/Other". The list of groups
are available in /usr/share/doc/rpm-*/GROUPS.

#09: As the INSTALL file in the source package and
http://menumaker.sf.net say, you don't need to build it to use
menumaker. You can simply copy the pure Python files. But,
byte-compiled ones run faster than code. As mentioned in the previous
posts on Python packaging, please go through them.

#10: %description line is too long! Please break it with newlines.

SK

-- 
Shakthi Kannan
http://www.shakthimaan.com


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]