[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: Change Request: Test unicode fixes on transifex on app4

On Wed, 2008-04-30 at 14:18 -0400, Ricky Zhou wrote:
> On 2008-04-30 02:12:01 PM, Ignacio Vazquez-Abrams wrote:
> > I'm not convinced that this shotgun approach is best. I recommend
> > applying the less-invasive attached patch and figuring out what's wrong
> > first.
> All right then, we're going to try and get a bit more information about
> where the problem is coming from first (adding those debugging
> statements now).  

This patch should fix it based on discussion in IRC.

Ignacio Vazquez-Abrams <ivazqueznet gmail com>
diff --git a/model.py b/model.py
index 00ff28a..30a2b3e 100644
--- a/model.py
+++ b/model.py
@@ -317,7 +317,7 @@ class Module(SQLObject):
         # TODO: Some maintainers might not want to push to main repo.
         # FIXME: Only commit files that have been changed.
         # Is this replacement necessary anymore?
-        msg_esc = commit_message.replace("'", "\'")
+        msg_esc = commit_message.replace("'", "\'").encode('utf-8')
         if self.repository.type == "cvs":
             coms.append({'args': ["cvs", "-z4", "commit", "-m", msg_esc],
                          'cwd': modulePath})

Attachment: signature.asc
Description: This is a digitally signed message part

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]