[PATCH FC6] x86_64 page_is_ram() uses __initdata; breaks /dev/crash and /dev/mem restriction

Pete Zaitcev zaitcev at redhat.com
Mon May 14 14:55:43 UTC 2007


On Thu, 26 Apr 2007 15:40:00 -0400, Dave Anderson <anderson at redhat.com> wrote:

> This is fine for upstream x86_64 kernels, because the e820 map never
> gets used during runtime.  But because we (RHEL/Fedora) have an x86_64
> version of page_is_ram(), it ends up using __init data.

> +++ linux-2.6.20.x86_64/arch/x86_64/kernel/e820.c	2007-04-26 14:38:24.000000000 -0400
> @@ -25,7 +25,7 @@
>  #include <asm/bootsetup.h>
>  #include <asm/sections.h>
>  
> -struct e820map e820 __initdata;
> +struct e820map e820;

ACK

Although, do we follow the ACK process for stable Fedora now? I thought
it was just the Chuck's judgement ever since he joined.

On Dave's side I looked at Rawhide just now and this does not seem to
be there either (on 1.3126), although linux-2.6-devmem.patch and Xen are.

-- Pete




More information about the Fedora-kernel-list mailing list