CONFIG_DEBUG_STACKOVERFLOW hurts

Dave Jones davej at redhat.com
Fri Sep 14 22:42:52 UTC 2007


On Sat, Sep 15, 2007 at 01:34:24AM +0300, Gilboa Davara wrote:
 
 > > In light of this, I'd like to propose that we turn off
 > > DEBUG_STACKOVERFLOW in Fedora, at least on x86/4KSTACKS.  I think it
 > > does more harm than good; the warning is going to turn deadly most of
 > > the time.
 > > 
 > Sorry for butting in... but isn't disabling STACKOVERFLOW the wrong
 > answer to this problem?
 > Does anyone see any reason why both sprint_symbol and __print_symbol
 > shouldn't use dynamically allocated buffers instead of wasting stack
 > space? *

I think the reason is that kmalloc can sleep, and those functions
may be called from code that can't sleep.

	Dave

-- 
http://www.codemonkey.org.uk




More information about the Fedora-kernel-list mailing list