shared /boot support. bz 197065

Thorsten Leemhuis fedora at leemhuis.info
Tue Mar 25 06:02:04 UTC 2008


On 24.03.2008 20:53, Jarod Wilson wrote:
> On Monday 24 March 2008 03:32:37 pm Dave Jones wrote:
>> I took a stab at bz 197065 and arrived at the patch below.
>> Would appreciate some eyeballs before I commit from people
>> familiar with the macro goo in the specfile. (Hi Roland!)
>>
>> Aparently pm-utils will need a change to cope with the changed
>> filename, but I think that should be the limit of the damage.
>> (oprofile will need to append the archname on the end of System.map-$ver
>> filenames, but they're user-passed anyway, and not coded anywhere afaik
>> Hmm. Not sure about Systemtap).
>> Comments?
> Yep!
>> -    install -m 644 .config $RPM_BUILD_ROOT/boot/config-$KernelVer
>> -    install -m 644 System.map $RPM_BUILD_ROOT/boot/System.map-$KernelVer
>> -    touch $RPM_BUILD_ROOT/boot/initrd-$KernelVer.img
>> +    install -m 644 .config $RPM_BUILD_ROOT/boot/config-$KernelVer.%{_arch}
>> +    install -m 644 System.map $RPM_BUILD_ROOT/boot/System.map-$KernelVer.%{_arch}
>> +    touch $RPM_BUILD_ROOT/boot/initrd-$KernelVer.img.%{_arch}
> For the sake of consistency, [...]

For the sake of consistency we IMHO should use the same delimiter 
between "$(uname -r)" and arch in all places. E.g. either "." (like 
quoted above) everywhere or a "-", like we already use in the devel 
packages (e.g. /usr/src/kernels/2.6.25-0.141.rc6.git5.fc9-x86_64).

CU
knurd




More information about the Fedora-kernel-list mailing list