[PATCH] modprobe: Read module options from kernel command line

[Dan Nicholson]

On Thu, Sep 4, 2008 at 2:13 PM, Pete Zaitcev <zaitcev at redhat.com> wrote:
> On Thu, 04 Sep 2008 13:54:18 -0700, Dan Nicholson <dbn.lists at gmail.com> wrote:
>
>> @@ -1586,6 +1626,7 @@ int main(int argc, char *argv[])
>>
>>               read_toplevel_config(config, "", 1, 0,
>>                            &modoptions, &commands, &aliases, &blacklist);
>> +             read_kcmdline(1, &modoptions);
>>               read_config(aliasfilename, "", 1, 0,&modoptions, &commands,
>>                           &aliases, &blacklist);
>>               read_config(symfilename, "", 1, 0, &modoptions, &commands,
>
> I see two of them. You didn't add it into insmod by any chance?
> If so, there has to be a way to override this.

I didn't add it into insmod. The first call to read_kcmdline() is
during the dump_only (-c) fast path. There's an exit(0) on the next
line after this hunk. The second call is during the normal loop over
the module names supplied. Later in that loop is where the actual
insmod/rmmod is performed in handle_module(). Is that what you're
asking?

--
Dan