2.6.29.1-102.fc11 --with vanilla broken

Kyle McMartin kyle at mcmartin.ca
Thu Apr 23 04:29:01 UTC 2009


On Wed, Apr 22, 2009 at 06:18:07PM -0400, Chuck Anderson wrote:
>   if ! egrep "^Patch[0-9]+: $patch\$" %{_specdir}/%{name}.spec ; then
>     if [ "${patch:0:10}" != "patch-2.6." ] ; then
>       echo "ERROR: Patch  $patch  not listed as a source patch in specfile"
>       exit 1
>     fi
>   fi 2>/dev/null
> 
> Why is it checking for "patch-2.6.*" in the patch file name?  I 
> removed that entire block of code and --with vanilla now works.  What 
> is the expected behavior of that block of code?
> 

Urgh. Yeah, this was added to check that ApplyPatch patches are also
listed in the srpm (if they aren't, then obviously we'll ftbfs... this
lets 'make prep' catch it.)

This rule should probably be updated to use an $specdir/exclude file or
something.

regards, Kyle




More information about the Fedora-kernel-list mailing list