mc packages need QA

[Jesse Keating]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Sunday 18 January 2004 22:50, Michael Schwendt wrote:
> My advice: take the original spec file, and for the first legacy update,
> fix it where necessary and where it seems reasonable (small adjustments
> like "Copyright -> License" or an updated URL don't hurt anyone unless
> the packager starts to rearrange the order of lines in the spec). Don't
> change the indendation or regroup fields. A diff against the previous
> release should stay straight-forward and readable. But do add missing
> build requirements and fix obvious package bugs.
>
> Right now the "mc" update ticket contains src.rpms which don't build due
> to terribly incomplete build requirements. For example, on rh73 with the
> 6.legacy package you'll get:
>
> [...]
> /usr/bin/ld: cannot find -ldb1
> collect2: ld returned 1 exit status
> make[3]: *** [plain-gmc] Error 1
> [...]
>
> Missing buildrequires db1-devel, at least. Skimming over the build log,
> also missing seem to be "gettext, slang-devel, e2fsprogs-devel,
> pam-devel", probably more, and that check took me only a minute (?)
> after the test-build failed. It took longer to write this
> message. "Buildrequires: slang" is wrong and a slip on Red Hat's
> part. Further, potential missing buildrequires are ncurses-devel and
> libtermcap-devel (didn't look a 2nd time) based on what "rpm -qR mc" of
> Red Hat's binary rpm returns.

Sound advice.  I'm sure a lot of these would have been caught by a proper 
build system.  Unfortunately ours isn't "proper" yet.  

Could you please add your comments to the bugzilla system?  If it's a 
blocker, then I'll re-roll the packages.  If we can go forward and fix in 
the future, I'd rather get the update out and published.

- -- 
Jesse Keating RHCE MCSE	(http://geek.j2solutions.net)
Fedora Legacy Team	(http://www.fedora.us/wiki/FedoraLegacy)
Mondo DevTeam		(www.mondorescue.org)
GPG Public Key		(http://geek.j2solutions.net/jkeating.j2solutions.pub)

Was I helpful?  Let others know:
 http://svcs.affero.net/rm.php?r=jkeating
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)

iD8DBQFAC4Pw4v2HLvE71NURAo8PAJwOEPfQ0QScV+XnKprZ1q0KXH2lCQCfbFcE
aPN1euqo/S3Fp2cQi5p6IyY=
=UsiR
-----END PGP SIGNATURE-----