[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[Fedora-livecd-list] Re: spec file : corrections needed



On 6/17/06, Chitlesh GOORAH <chitlesh fedoraproject org> wrote:
chitlesh(i386)[0]$rpmlint -i kadischi-2.1-2.20060616cvs.i386.rpm
W: kadischi no-version-in-last-changelog
The last changelog entry doesn't contain a version. Please insert the
version that is coherent with the version of the package and rebuild it.

We should use the FE format
* Fri Jun 16 2006 Chitlesh Goorah <chitleshATfedoraprojectDOTorg> -
2.1-2.20060617cvs

E: kadischi script-without-shellbang /usr/share/doc/kadischi-2.1/COPYING
This executable text file does not contain a shebang, thus it cannot be
properly executed.  Often this is a sign of spurious executable bits for a
non-script file, but can also be a case of a missing shebang.  To fix this
error, find out which case of the above it is, and either remove the
executable bits or add the shebang.

Ive chmod 644 COPYING and already committed it to cvs

E: kadischi script-without-shellbang /usr/share/kadischi/lib/shvar.py
This executable text file does not contain a shebang, thus it cannot be
properly executed.  Often this is a sign of spurious executable bits for a
non-script file, but can also be a case of a missing shebang.  To fix this
error, find out which case of the above it is, and either remove the
executable bits or add the shebang.


I've chmod 644 %{buildroot}%{_datadir}/%{name}/lib/shvar.py


E: kadischi zero-length /usr/share/doc/kadischi-2.1/NEWS


I chose to drop NEWS because its empty and its useless.


I haven't worked on these yet:

E: kadischi arch-dependent-file-in-usr-share
/usr/share/kadischi/install/scanswap
This package installs an ELF binary in the /usr/share
 hierarchy, which is reserved for architecture-independent files.

E: kadischi arch-dependent-file-in-usr-share
/usr/share/kadischi/initrd/find-live-cd
This package installs an ELF binary in the /usr/share
 hierarchy, which is reserved for architecture-independent files.


The patch is attached to this mail.


--
http://clunixchit.blogspot.com
--- kadischi.spec	2006-06-16 21:11:38.000000000 +0200
+++ SPECS/kadischi.spec	2006-06-17 13:50:00.000000000 +0200
@@ -24,20 +24,19 @@
 %prep
 %setup -q -n %{name}
 
-
 %build
-glib-gettextize --copy --force
 intltoolize --copy -f --automake
-aclocal -I .
-autoconf
-automake --add-missing --copy
+%{__aclocal}
+%{__autoconf}
+%{__automake} --add-missing --copy
+
 %configure
 make %{?_smp_mflags}
 
-
 %install
 rm -rf %{buildroot}
 make install DESTDIR=%{buildroot}
+chmod 644 %{buildroot}%{_datadir}/%{name}/lib/shvar.py
 
 
 %clean
@@ -45,8 +44,8 @@
 
 
 %files
-%defattr(-,root,root,-)
-%doc FAQ README NEWS TODO COPYING CREDITS
+%defattr(-,root,root, -)
+%doc FAQ README TODO COPYING CREDITS
 %dir %{_datadir}/%{name}
 %dir %{_sysconfdir}/%{name}
 %config(noreplace) %{_sysconfdir}/%{name}/buildstamp
@@ -79,6 +78,12 @@
 %ghost %{_datadir}/%{name}/post_install_scripts/*.pyo
 
 %changelog
+* Fri Jun 16 2006 Chitlesh Goorah <chitlesh fedoraproject org> - 2.1-2.20060617cvs
+- dropped empty NEWS from %doc
+- don't glib-gettextize (breaks locale creation)
+- fix script-without-shellbang rpmlint errors
+
+
 * Fri Jun 16 2006 <jasperhartline adelphia net>
 - Default standard-livecd.cfg password changes
 

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]