Spaces vs tabs (was Re: [Fedora-livecd-list] squashfs -- anyone have a pristine tree?)

[Toshio Kuratomi]

On Thu, 2006-03-30 at 00:12 -0600, J. Hartline wrote:
> Toshio Kuratomi wrote:
> 
> >Here's two patches.  The first one enables squashfs.  In order to use it
> >you invoke kadischi with the --filesystem option::
> >
> >  
> >
> Everything was committed to CVS except for the last two file patches.
> I think we can come up with a better solution than to polish something 
> that seems out of place already. :-P
> In addition to the SquashFS capability as an option and the rest of the 
> patches I went ahead
> and situated the manual pages, and changed over to using kadischi.conf 
> rather than build.conf.

Great!

I noticed one issue.  Looks like your patches use 8 spaces whereas the
original code uses tabs.  python will interpret this without complaining
(unless tab-nanny, python -tt, is turned on) but it leads to unreadable
code when some reads it with tabstops set to another number.  So it's
just plain poor practice to mix tabs and spaces.

I'll go through and normalize the code and add the -tt option so python
stops us from doing this continuously, but we need to decide what style
of indentation we like and use it throughout.

Here's my short list of candidates.
* tabs
* 4 spaces
* 8 spaces

I prefer 4 spaces per the python style guidelines::
  http://www.python.org/dev/peps/pep-0008/

-Toshio
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 191 bytes
Desc: This is a digitally signed message part
URL: <http://listman.redhat.com/archives/fedora-livecd-list/attachments/20060330/a16f18f2/attachment.sig>