[Fedora-livecd-list] [PATCH 1/6] Set the build directory

[Jeremy Katz]

On Tue, 2007-08-07 at 23:28 +0200, Jeroen van Meeuwen wrote:
> There's an addition problem with having tempfile.mkdtemp(), and that is
> that mounts can not easily be unmounted in a next run, if the creation
> of live media fails in one way or the other. Having a "static"
> build_dir, it can be used to check for existance, and be unmounted.
> You'd not be running out of loop devices anymore. If the directory
> already exists, the app complains and exits appropriately, or allows the
> user to act upon it and save his data.

What/how are you expecting the user to do on the failure?  Why not
teardown immediately on failure (or at least, before you throw away the
object you had)?  Outside of cases where we're currently traceback'ing
and not catching it[1], livecd-creator should be cleaning up after
itself on error pretty much all the time and thus not running out of
loop devices

Jeremy

[1] Hopefully a dwindling number...  it seems to be, but if there are
other cases people hit, let me know either by filing a bug or sending a
patch!