[Fedora-livecd-list] [PATCH 2/7] livecd: remove ignore-deleted option
Jeremy Katz
katzj at redhat.com
Mon Sep 17 18:41:56 UTC 2007
On Mon, 2007-09-17 at 13:29 -0500, Douglas McClendon wrote:
> Jeremy Katz wrote:
> > On Mon, 2007-09-17 at 12:24 -0500, Douglas McClendon wrote:
> >> ignore-deleted isn't an option worth keeping around
> >
> > The main (albeit, not the best in the world :) reason that I've kept it
> > thus far is that it speeds up builds when just testing a livecd-creator
> > change.
> >
> > But assuming the rest requires this,
>
> It does require it. But in a prior version of the patch, I had both
> ignore-deleted and turbo-liveinst as options which were mutually
> exclusive. Thus if you really wanted to, you could keep the
> ignore-deleted option, as long as you made the genMinInstDelta call
> conditional upon it. Thus making the code in liveinst.sh that detects
> the absence of the delta technically not purely legacy.
>
> The sentence at the top there does not reflect a strong opinion. I can
> see value in speeding up the build (~20-25% if I recall). But there is
> also some value in the removed complexity. Your call.
For now, I've removed it. If I get annoyed at the time hit, I might
change my mind in the future :)
Jeremy
More information about the Fedora-livecd-list
mailing list