[Fedora-livecd-list] imgcreate/kickstart.py

Jeremy Katz katzj at fedoraproject.org
Wed Jun 4 19:42:29 UTC 2008


 imgcreate/kickstart.py |    1 +
 1 file changed, 1 insertion(+)

New commits:
commit b1c1d66c7e22c07911ca0843106f8b69f5c0edf7
Author: Eric Paris <eparis at redhat.com>
Date:   Wed Jun 4 15:10:25 2008 -0400

    FD leak in kickstart.py
    
    Found 2 FD's that never got closed in kickstart.py
    
    There are still a UDP and TCP socket open when we are going rpm calls
    and I have no idea why.  Maybe someone else know why we would have 2
    such things open and where they should be closed?

diff --git a/imgcreate/kickstart.py b/imgcreate/kickstart.py
index 6e946b2..c83e795 100644
--- a/imgcreate/kickstart.py
+++ b/imgcreate/kickstart.py
@@ -382,6 +382,7 @@ class SelinuxConfig(KickstartConfig):
             path = self.path(fn)
             f = file(path, "w+")
             os.chmod(path, 0644)
+            f.close()
 
         if ksselinux.selinux == ksconstants.SELINUX_DISABLED:
             return





More information about the Fedora-livecd-list mailing list