[Fedora-livecd-list] [PATCH] livecd-iso-to-disk giving wrong directory path to extlinux

[Warren Togami]

Warren Togami wrote:
> There is a similar problem with vfat filesystems, where syslinux is a 
> path that does not exist, and mmove subsequently segfaults because it 
> doesn't know how to handle it.  I'm working on that issue separately.
> 

The previous patch to make the extlinux code-path work is confirmed to work.

The syslinux code path however is proving to be trickier.  It appears 
that livecd-iso-to-disk is doing something wrong, then mmove via 
syslinux crashes.  mtools itself is buggy in crashing here, but it 
appears to be livecd-iso-to-disk's fault.  I am still figuring this...

Core was generated by `mmove -D o -D O s:/ldlinux.sys 
s:/LiveOS/syslinux/ldlinux.sys'.
Program terminated with signal 11, Segmentation fault.
#0  0x080610ef in _mwrite_one (Dir=0x0, argname=0x9b99f40 "ldlinux.sys", 
shortname=0x0, cb=0x8062a1c <renameit>,
     arg=0xbffcb060, ch=0xbffcb53c) at mk_direntry.c:522
522		doscp_t *cp = GET_DOSCONVERT(Dir);
(gdb) bt
#0  0x080610ef in _mwrite_one (Dir=0x0, argname=0x9b99f40 "ldlinux.sys", 
shortname=0x0, cb=0x8062a1c <renameit>,
     arg=0xbffcb060, ch=0xbffcb53c) at mk_direntry.c:522
#1  0x080614c9 in mwrite_one (Dir=0x0, _argname=0xbffcb138 
"ldlinux.sys", _shortname=0x0, cb=0x8062a1c <renameit>,
     arg=0xbffcb060, ch=0xbffcb53c) at mk_direntry.c:639
#2  0x08062dac in rename_file (entry=0xbffcab6c, mp=0xbffcb068) at 
mmove.c:132
#3  0x08055be6 in handle_leaf (direntry=0xbffcab6c, mp=0xbffcb068, 
lookupState=0x0) at mainloop.c:224
#4  0x0805630d in recurs_dos_loop (mp=0xbffcb068, filename0=0xbffcb914 
"ldlinux.sys", filename1=0x0, lookupState=0x0)
     at mainloop.c:389
#5  0x08056507 in common_dos_loop (mp=0xbffcb068, pathname=0xbffcb913 
"/ldlinux.sys", lookupState=0x0, open_mode=2)
     at mainloop.c:437
#6  0x0805657e in dos_loop (mp=0xbffcb068, arg=0xbffcb911 
"s:/ldlinux.sys") at mainloop.c:450
#7  0x08056890 in main_loop (mp=0xbffcb068, argv=0xbffcb7a8, argc=1) at 
mainloop.c:553
#8  0x08063414 in mmove (argc=7, argv=0xbffcb794, oldsyntax=0) at 
mmove.c:302
#9  0x08066d26 in main (argc=7, argv=0xbffcb794) at mtools.c:167

Warren Togami
wtogami at redhat.com