The open() system call in f8 really broken...

Eric Sandeen sandeen at redhat.com
Thu Aug 16 22:32:21 UTC 2007


Jakub Jelinek wrote:

> The right fix is to use one of:
> retval = (test_io_backing_manager->open)(name, flags, &data->real);
> retval = (*test_io_backing_manager->open)(name, flags, &data->real);

One unfortunate side-effect of this is that cscope doesn't find these as
"open" callers now.  Maybe I need a smarter cscope.  It gets it to
build, though.

> retval = test_io_backing_manager->(open)(name, flags, &data->real);

FWIW this didn't help, build failed same as before.

-Eric

> or, far less desirable, but what standard allows,
> #undef open
> above this.  The last one means that no open(1) error checking will be
> done in the rest of the source file, which is not a good idea.
> 
> 	Jakub




More information about the Fedora-maintainers mailing list